Bug 106668 - Aperture space rollback snafu
Summary: Aperture space rollback snafu
Status: RESOLVED MOVED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Intel 3D Bugs Mailing List
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-26 16:30 UTC by Chris Wilson
Modified: 2019-09-25 19:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Wilson 2018-05-26 16:30:31 UTC
Since we may update context state as we compute the batch, that state is preserved as we rollback the batch for a failed aperture check -- the subsequent emission then skips the atoms as the context state is believed to match requirements.

E.g. gen7_upload_urb(). 

Affects:
genX(blorp_exec)
brw_dispatch_compute_common
brw_draw_single_prim

The aperture rollback has been in place since

commit 3d851ae48865ac6a20a615e6e06d913c2265cda5
Author: Eric Anholt <eric@anholt.net>
Date:   Sat Oct 22 09:37:57 2011 -0700

    i965: Use the batch save/reset code to avoid needing the BO validate step.

7.10-branchpoint-6137-g3d851a!

The issue with believing global state for urb in particular seems to be from

commit d5e217dbfda2a87e149bdc8586c25143fc0ac183
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Fri Aug 18 16:10:39 2017 -0700

    i965: Stop looking at NewDriverState when emitting 3DSTATE_URB
    
I'm not sure if that's the only instance.
Comment 1 GitLab Migration User 2019-09-25 19:11:23 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1728.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.