Bug 10816 - ANSI-fy libX11
Summary: ANSI-fy libX11
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL: http://lists.freedesktop.org/archives...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-30 00:17 UTC by Magnus Kessler
Modified: 2007-06-11 00:52 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
ANSI-fy libX11 (194.78 KB, patch)
2007-04-30 00:29 UTC, Magnus Kessler 		no flags Details | Splinter Review
Better patch (192.61 KB, patch)
2007-04-30 02:47 UTC, Tilman Sauerbeck 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Magnus Kessler 2007-04-30 00:17:52 UTC 
As a first step to using code checking tools such as "sparse" on the current libX11 code base it has to be converted from its current mix of K&R and ANSI function declarations to pure ANSI. I attach a patch that does this. Further discussion on [0] and [1]

[0] http://lists.freedesktop.org/archives/xorg/2007-February/021553.html
[1] http://lists.freedesktop.org/archives/xorg/2007-April/024065.html
Comment 1 Magnus Kessler 2007-04-30 00:29:34 UTC 
Created attachment 9813 [details] [review]
ANSI-fy libX11

The full patch set in one file
Comment 2 Tilman Sauerbeck 2007-04-30 02:47:49 UTC 
Created attachment 9817 [details] [review]
Better patch

Here's a slightly tweaked version of your patch.

I removed rogue changes that crept it, such as the CHECKER stuff, an "extern" you removed, and a few unrelated whitespace changes.

No object files were changed in the testing of that patch, which is cool. I can commit this, but I want to wait a bit just in case anyone else finds a problem with this patch.
Comment 3 Tilman Sauerbeck 2007-05-01 10:16:10 UTC 
Committed in a48386ce6b5f8fd2d9dc11a966c9bf5da59f3831.
Comment 4 Stefan Dirsch 2007-06-11 00:52:43 UTC 
One hunk was wrong. See Bug #11222.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.