The setting of buggy_repeat is based on ServerVendor and VendorRelease. But now the buggy_repeat path is obsolete for Xsun, especially when xrender is enabled
Created attachment 9904 [details] [review]
to remove the buggy_repeat path
What do you mean? You mean that no version of Sun's X server has the bug?
Yes, actually I submitted the original patch for this. Sun never released a version of Solaris with Xorg with the buggy repeat problem. This patch was only needed for development versions of Solaris Nevada (roughly builds 25-30). The latest S10U release and Nevada releases have a fixed Xorg. So no users should ever encounter this bug.
We need to remove this test because Xsun has the same VendorString and a lower VendorRelease number so it falsely triggers buggy_repeat to be turned on. They just added Xrender support recently to Xsun, so this wasn't an issue before recently.
By the way, thank you very much for providing the detailed explanation.
It's extremely useful for us to have details like that in our code's history.