Bug 110475 - Add 0x3E98 to src/intel_module.c
Summary: Add 0x3E98 to src/intel_module.c
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: Chris Wilson
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-20 06:53 UTC by David Bartley
Modified: 2019-11-27 13:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description David Bartley 2019-04-20 06:53:51 UTC
I have an intel chipset/CPU that reports a VGA adapter with PCI ID 3E98.  That ID is already registered in src/i915_pciids.h, but not in src/intel_module.c.  That causes the xorg log to contain "gen9 engineering sample" rather than "HD Graphics" as expected.  Below is a trivial patch to add support for this PCI ID:

diff --git a/src/intel_module.c b/src/intel_module.c
index a8c9768e..059b9310 100644
--- a/src/intel_module.c
+++ b/src/intel_module.c
@@ -317,6 +317,7 @@ static const SymTabRec intel_chipsets[] = {
        {0x3E9A, "HD Graphics"},
        {0x3E9B, "HD Graphics"},
        {0x3E94, "HD Graphics"},
+       {0x3E98, "HD Graphics"},
        {0x3EA1, "HD Graphics"},
        {0x3EA4, "HD Graphics"},
        {0x3EA0, "HD Graphics"},
Comment 1 David Bartley 2019-04-20 06:55:09 UTC
One observation is that it'd be nice to write a unit test that validates that if an ID appears in src/i915_pciids.h, it must also appear in src/intel_module.c, to prevent future issues like this.
Comment 2 Martin Peres 2019-11-27 13:50:17 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/issues/162.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.