Bug 13798 - xf86-video-i810 2.1.1 or later fails to build against a server that has no DRI support
Summary: xf86-video-i810 2.1.1 or later fails to build against a server that has no DR...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Jesse Barnes
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-23 14:04 UTC by Carlo Marcelo Arenas Belon
Modified: 2008-01-03 11:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
path to git's head that fixes the problem for >=2.1.1 (1.19 KB, patch)
2007-12-23 14:08 UTC, Carlo Marcelo Arenas Belon 		no flags Details | Splinter Review
View All

Description Carlo Marcelo Arenas Belon 2007-12-23 14:04:00 UTC 
building intel driver 2.1.1 or later results against an xorg server that has no DRI support results in the following error :

i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -I/usr/include/xorg -DI830_XV -DI830_USE_XAA -DI830_USE_EXA -O2 -march=prescott -pipe -MT i810_driver.lo -MD -MP -MF .deps/i810_driver.Tpo -c i810_driver.c  -fPIC -DPIC -o .libs/i810_driver.o
In file included from i810_driver.c:88:
i830.h:137: error: expected specifier-qualifier-list before 'uint64_t'
i830.h:240: error: expected specifier-qualifier-list before 'uint64_t'
make[3]: *** [i810_driver.lo] Error 1
Comment 1 Carlo Marcelo Arenas Belon 2007-12-23 14:08:09 UTC 
Created attachment 13333 [details] [review]
path to git's head that fixes the problem for >=2.1.1

This patch complements 88f8b688e2316ae4a1f7485f0010ce90de54783a which
added uint64_t typed variables to avoid unsigned long overflows in
32-bit architectures but didn't include <stdint.h> with the required
definition.
    
when XF86DRI and _XF86DRI_SERVER_ are defined this header gets
indirectly included through "i830_dri.h", thanks to "i830_common.h"
which masquerades this problem as released in 2.1.0 and that manifests
with :
    
In file included from i810_driver.c:88:
i830.h:137: error: expected specifier-qualifier-list before 'uint64_t'
i830.h:240: error: expected specifier-qualifier-list before 'uint64_t'
Comment 2 Michael Fu 2007-12-23 16:35:11 UTC 
re-assign to jesse to see if the fix makes sense...
Comment 3 Jesse Barnes 2008-01-03 11:14:28 UTC 
Yeah, fix looks good to me, thanks Carlos.  I'll go ahead and push it.
Comment 4 Jesse Barnes 2008-01-03 11:16:54 UTC 
Fixed by f2ffc0f6e038357dda268363e52c11ada1d0b810

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.