Bug 1409 - Numerous portability problems in savage driver
Summary: Numerous portability problems in savage driver
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/savage (show other bugs)
Version: git
Hardware: x86 (IA32) OpenBSD
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-18 09:02 UTC by Matthieu Herrb
Modified: 2004-12-01 00:17 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
proposed patch (8.43 KB, patch)
2004-09-18 09:03 UTC, Matthieu Herrb 		no flags Details | Splinter Review
Updated patch (7.12 KB, patch)
2004-09-27 23:34 UTC, Matthieu Herrb 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Matthieu Herrb 2004-09-18 09:02:23 UTC 
Trying to build HEAD on OpenBSD/i386 and OpenBSD/amd64 reveals several 
portability problems:

- this driver was not tested with DoLoadableServer NO
- this driver was not tested with BuildXF86DRI NO
- this driver redefines uint, and ulong types in a non portable way.
Comment 1 Matthieu Herrb 2004-09-18 09:03:14 UTC 
Created attachment 933 [details] [review]
proposed patch
Comment 2 Matthieu Herrb 2004-09-27 23:34:38 UTC 
Created attachment 972 [details] [review]
Updated patch 

Some issues where fixed
Comment 3 Alex Deucher 2004-09-29 22:34:01 UTC 
I've committed these.  Thanks.
Comment 4 Adam Jackson 2004-12-01 19:17:14 UTC 
closing, these have been applied.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.