Bug 14432 - No-TV quirk for 17aa:201a wrong, missing tv-out on Z61t
Summary: No-TV quirk for 17aa:201a wrong, missing tv-out on Z61t
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Wang Zhenyu
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-08 14:09 UTC by Tomasz Torcz
Modified: 2008-02-28 12:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Tomasz Torcz 2008-02-08 14:09:24 UTC
I'm using Ubuntu developer version (hardy) on Thinkpad Z61t with Intel chipset. Some time ago I've lost ability to control TV output with xrandr.

Snippet from lspci -vvvn:
00:00.0 0600: 8086:27a0 (rev 03)
        Subsystem: 17aa:2017
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
        Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ >SERR- <PERR-
        Latency: 0
        Capabilities: [e0] Vendor Specific Information

00:02.0 0300: 8086:27a2 (rev 03) (prog-if 00 [VGA controller])
        Subsystem: 17aa:201a
        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
        Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
        Latency: 0
        Interrupt: pin A routed to IRQ 20
        Region 0: Memory at ee100000 (32-bit, non-prefetchable) [size=512K]
        Region 1: I/O ports at 1800 [size=8]
        Region 2: Memory at d0000000 (32-bit, prefetchable) [size=256M]
        Region 3: Memory at ee200000 (32-bit, non-prefetchable) [size=256K]
        Capabilities: [90] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
                Address: 00000000  Data: 0000
        Capabilities: [d0] Power Management version 2
                Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
                Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:02.1 0380: 8086:27a6 (rev 03)
        Subsystem: 17aa:201a
        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
        Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
        Region 0: Memory at ee180000 (32-bit, non-prefetchable) [size=512K]
        Capabilities: [d0] Power Management version 2
                Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
                Status: D0 PME-Enable- DSel=0 DScale=0 PME-

TV-out gone missing because of this quirk:

    /* Lenovo X60s has no TV output */
    { PCI_CHIP_I945_GM, 0x17aa, 0x201a, quirk_ignore_tv },

Let me repeat: I have Lenovo Thinkpad Z61t WITH TV-Output. This quirk should be removed or tailored to X60. It's better to show non-connected output than disable perfectly working output.

This is also https://bugs.launchpad.net/bugs/178505
Comment 1 Wang Zhenyu 2008-02-11 07:38:34 UTC
Yeah, I've also seen one z61 with s-video tv out, so only subsystem ids aren't enough for quirks, and we should find other ways that may be brand specific or bios specific or others.

For thinkpad/lenovo, bios id is suggested to be used, but unfortunately kernel thinkpad_acpi module doesn't export bios_model in sysfs, otherwise we can use 
it to identify thinkpad versions. And current driver has no way to extract dmi bios info, which needs extra work.

I might have to revert origin x60 tv quirks, as for z61 users they have no way except removing that quirk code line to enable tv output. Or we have option to disable all kinds of quirks...
Comment 2 Wang Zhenyu 2008-02-17 22:38:30 UTC
DMI based quirk patch has been pushed. 

Pls pull git master to see if it fixes your problem.
Comment 3 Wang Zhenyu 2008-02-18 07:15:20 UTC
mark as fixed.
Comment 4 Tomasz Torcz 2008-02-28 12:49:47 UTC
Yes, fixed. I just testes Ubuntu package and TV out is here. Thank you very much!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.