I'll attach 3 patches required for gb18030 support. SuSE got them by SUN (AFAIK originally made by James Su) and James Su made fixes later for them. Needs to be discussed.
Created attachment 1051 [details] [review] p_XFree86-4.2.0-i18n-xlib-20020322.diff
Created attachment 1052 [details] [review] p_XFree86-4.3.0-i18n-font_encodings-20030609.diff
Created attachment 1053 [details] [review] p_XFree86-4.3.0-i18n-nls-20030609.diff
Needs to be discussed outside of Bugzilla first.
reopen for discussion.
Needs to be discussed with Mike and James. Mike, would you please add James
The big converting tables in p_XFree86-4.2.0-i18n-xlib-20020322.diff are considered problematic and might better be replaced with the use of glibc.
I would like to commit Attachment #1052 [details] and #1053. However I'm unable to test this at all. James, could you please add a commtent what those patches do and if you think they are OK? I also would need to know the original author. James, did you do them?
Hi, Yes, these patches were written by me, in order to let XFree86 support GB18030, GBK and BIG5-HKSCS locales correctly. These patches have been used in many distributions for years, eg. TurboLinux, RedHat, SuSE, and some local distributions in China. I had submitted them to XFree86 group, but had not been accepted yet. Patch p_XFree86-4.2.0-i18n-xlib-20020322.diff is necessary to support GB18030 locale, so please consider to commit it. James Su
> I had submitted them to XFree86 group, but had not been accepted yet. Yes, I know. It was partly my fault. The problem was that there were several different versions of these patches floating around which differed slightly. Attachment 1052 [details] and 1053 are committed to X.Org now. I need to think how to handle the big conversion tables. Maybe I make them optional.
Whats the status of this bug today? Should it be closed?
No, attachment #51 [details] [review] is still not committed.
Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Egbert? SUSE is now using the remaining patch since about 6 years ...
Patch committed now to libX11 git head. commit 67e34d7a82ccd31f1208c0c43a6d58c3c05bf51a Author: Stefan Dirsch <sndirsch@suse.de> Date: Sat Nov 22 19:40:54 2008 +0100 Added remaining xlib patch required for gb18030 support (#1573).
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.