Created attachment 18528 [details] [review]
libXau 1.0.3 Makefile.am patch
If I run "make -n" in the libXau directory, I get the following error:
true ' [LD ] libXau.la'
/bin/sh ./libtool --tag=CC --mode=link gcc -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -g -O2 -o libXau.la -rpath /usr/local/lib -version-number 6:0:0 -no-undefined AuDispose.lo AuFileName.lo AuGetAddr.lo AuGetBest.lo AuLock.lo AuRead.lo AuUnlock.lo AuWrite.lo
sed 's/__xorgversion__/"libXau 1.0.3" "X Version 11"/' \
< ./Xau.man > Xau.3
make: *** No rule to make target `XauFileName.3', needed by `all-am'. Stop.
make: Leaving directory `/tmp/libXau-1.0.3'
make: *** [all] Error 2
Then, if I look at Makefile.am, there is not rule for those files, only a "shadows.DONE" rule creating the needed files.
In addition, this shadows.DONE rule is just a shell loop, so it's really something that can be done with Makefile rules, with multiple benefits: rules requiring those files will not fail, make -n will not fail, and it'll be possible to create those files in parallel (but the speed is not really an issue).
See the attached patch, which provide a simple rule to create those files instead of using the shadows.DONE rule.
Thanks - fix committed to git master for libXau 1.0.4 release:
Author: Damien Thébault <email@example.com>
Date: Tue Aug 26 14:16:44 2008 -0700
Bug 17314: libXau's Makefile.am should have proper man creation rules
X.Org Bugzilla #17314 <http://bugs.freedesktop.org/show_bug.cgi?id=17314>
Patch #18528 <http://bugs.freedesktop.org/attachment.cgi?id=18528>
Signed-off-by: Alan Coopersmith <firstname.lastname@example.org>