Bug 17899 - System Update Completed dialog not translatable
Summary: System Update Completed dialog not translatable
Alias: None
Product: PackageKit
Classification: Unclassified
Component: client-library (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
Depends on:
Reported: 2008-10-04 03:29 UTC by Ville-Pekka Vainio
Modified: 2008-10-05 12:08 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Add the translatables with glade (4.36 KB, patch)
2008-10-05 08:49 UTC, Ville-Pekka Vainio
Details | Splinter Review

Description Ville-Pekka Vainio 2008-10-04 03:29:44 UTC
After doing a system update with gpk-update-viewer, it pops up a dialog window saying "System Update Completed - All selected updates have been successfully installed".

Neither of these two messages are translated, even when using a current po file with all messages in the po translated. These two messages aren't in the pot file at all. The following message is in the pot file: "System update completed". Please note this is different from "System Update Completed", which is what's shown in the GUI.

I have almost no GTK experience, but I think the messages might be coming from Glade and their translation isn't handled somehow. Apparently this dialog is shown in gpk-update-viewer.c in the function gpk_update_viewer_check_blocked_packages.
Comment 1 Ville-Pekka Vainio 2008-10-04 10:29:17 UTC
I noticed the text fields in the dialog are not marked as translatable in glade. I can provide I patch later, when I have the time to test it.
Comment 2 Ville-Pekka Vainio 2008-10-05 08:49:55 UTC
Created attachment 19388 [details] [review]
Add the translatables with glade

This patch adds translatable="yes" to the text elements of that dialog window. I've tested it and it works, these texts have been translatable before, so for some languages the translations may still be in the po files and in that case this patch won't even introduce new untranslated strings.

I made this with glade-3 on Fedora 9, for some reason glade also changed (probably just re-arranged) some other parts of the file. If you want a "hand-edited" patch without those changes, I can also make one, this is just direct output from glade.
Comment 3 Richard Hughes 2008-10-05 10:03:07 UTC
Hey dude, I edited the file with rawhide -- that's probably the reason. I've twiddled those bits in git -- can you give it a go please?
Comment 4 Ville-Pekka Vainio 2008-10-05 12:08:20 UTC
Just tested with latest git, seems to work fine. Thanks Richard, I'll close the bug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.