Bug 18065 - Glyphs are vertically cut of if software rendered composite is used
Summary: Glyphs are vertically cut of if software rendered composite is used
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Acceleration/EXA (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 18019 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-14 14:38 UTC by Maarten Maathuis
Modified: 2008-11-08 03:38 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Maarten Maathuis 2008-10-14 14:38:24 UTC
A typical case for this is a driver that doesn't support rendering to PICT_A8 destinations. The problem was introduced with the GlyphCache. I tried to locate the problem, but could find no obvious cause. The problem seems to hardware independent. I just wanted to report it officially, so it doesn't get lost.
Comment 1 Maarten Maathuis 2008-10-15 07:24:54 UTC
The bad beheaviour disappears if i disable the migration optimisation, so there's probably a problem with the damage reporting somewhere. Haven't narrowed it down further yet.
Comment 2 Eric Anholt 2008-11-07 13:11:41 UTC
If EXA optimizations are broken, they should be disabled.  Blocking core optimizations due to broken optimizations for broken drivers is not the way forward.

Comment 3 Michel Dänzer 2008-11-07 14:49:20 UTC
(In reply to comment #2)
> If EXA optimizations are broken, they should be disabled.  Blocking core
> optimizations

What's blocking what?

> due to broken optimizations for broken drivers is not the way forward.

The optimization only does the wrong thing when damage isn't tracked correctly. Apparently that's the case somewhere in the glyph cache code.
Comment 4 Michel Dänzer 2008-11-07 16:36:44 UTC
commit 21c116219cd5c6845a0955f2d88fdb5fab5c17cf
Author: Michel Dänzer <michel@tungstengraphics.com>
Date:   Sat Nov 8 01:25:14 2008 +0100

    Fix typos which caused exaCompositeRects() to use an incorrect damage region.

Thanks to Maarten for spotting the second typo.
Comment 5 Michel Dänzer 2008-11-08 03:38:52 UTC
*** Bug 18019 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.