Bug 1813 - xorgconfig gives up too easily on bad input
Summary: xorgconfig gives up too easily on bad input
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xorgconfig (show other bugs)
Version: 6.8.0
Hardware: All All
: medium minor
Assignee: Alan Coopersmith
QA Contact:
Depends on:
Reported: 2004-11-09 19:13 UTC by Alan Coopersmith
Modified: 2004-11-09 00:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Patch to xorgconfig.c (1.98 KB, patch)
2004-11-09 19:16 UTC, Alan Coopersmith
no flags Details | Splinter Review

Description Alan Coopersmith 2004-11-09 19:13:52 UTC
[Originally reported to Sun as Solaris bug id #5070654]

If one enters a bad file name to save the data that's been painfully
entered into the tool, it doesn't give you a chance to recover. It
simply exits. The result is that one is left with the pain of 
re-entering all the data again.

The same happens if the wrong amount of video memory is entered.
Comment 1 Alan Coopersmith 2004-11-09 19:16:35 UTC
Created attachment 1264 [details] [review]
Patch to xorgconfig.c

Fix developed by Derek Wang at Sun:

The following will be fixed:
1. xorgconfig exit if users input invalid amount of video memory.
2. xorgconfig exit if users input bad file name.

The fix will be that xorgconfig never exit only because users input some wrong
number or bad file name, users are given unlimited chances to try the right
number or file name until users choose giving up.
Comment 2 Alan Coopersmith 2004-11-09 19:17:45 UTC
Fix committed to Xorg cvs head:

2004-10-05  Alan Coopersmith  <alan.coopersmith@sun.com>

	* xc/programs/Xserver/hw/xfree86/xf86config/xorgconfig.c:
	Make xorgconfig ask again instead of giving up and throwing
	away all your answers when you give a bad file name or bad
	amount of video RAM.  (Sun bug id 5070654, Xorg bugzilla #1813
 	- fix from Derek Wang of Sun)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.