Bug 19421 - Gnome PackageKit should not allow entry of bad search chars on Enter
Summary: Gnome PackageKit should not allow entry of bad search chars on Enter
Status: RESOLVED WONTFIX
Alias: None
Product: PackageKit
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-06 02:32 UTC by Dwayne Bailey
Modified: 2012-01-05 10:08 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dwayne Bailey 2009-01-06 02:32:51 UTC
If you enter a \ in gpk-application's search text area although the 'Find' button disables you can still hot 'Enter' and get an error dialog.

My suggestions:
1) Disallow entry of unaccepted characters.  I'm not sure what the HIG says but I think it would be nicer to simply disallow \ as a valid character or filter out those characters before a search

2) Disable enter on that entry at the same time as you disable the 'Find' button
Comment 1 Richard Hughes 2009-01-08 06:14:22 UTC
I don't think we should just ignore characters -- then we get angry users thinking their keyboard has a fault. I also don't think we should just ignore the <enter> when there is invalid text -- then we get bugs about "certain search works being ignored".
Comment 2 Dwayne Bailey 2009-01-14 01:08:06 UTC
Yes hard call, which I guess is your call ;)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.