Bug 20937 - [PATCH] Missing pkgconfig check on gthread
Summary: [PATCH] Missing pkgconfig check on gthread
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
Keywords: patch
Depends on:
Reported: 2009-03-29 16:13 UTC by Brian Pepple
Modified: 2009-04-16 02:24 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Add pkgconfig check for gthread (727 bytes, patch)
2009-03-29 16:13 UTC, Brian Pepple
Details | Splinter Review
tp-gabble build log failure. (218.44 KB, text/plain)
2009-03-29 16:14 UTC, Brian Pepple

Description Brian Pepple 2009-03-29 16:13:58 UTC
Created attachment 24357 [details] [review]
Add pkgconfig check for gthread

Looks like tp-gabble is missing a check on gthread in configure.ac.  Seems in recent versions of tp-gabble is using 'g_thread_init' which requires gthread-2.0 to be linked.  I'll attach a simple patch to fix this, and also a copy of the build failure log that shows the problem.
Comment 1 Brian Pepple 2009-03-29 16:14:45 UTC
Created attachment 24358 [details]
tp-gabble build log failure.
Comment 2 Guillaume Desmottes 2009-04-14 07:42:27 UTC
I imported your patch to this branch: http://git.collabora.co.uk/?p=user/cassidy/telepathy-gabble;a=shortlog;h=refs/heads/gthread
Comment 3 Guillaume Desmottes 2009-04-16 02:24:37 UTC
Fixed in master.
Thanks for the patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.