Bug 21339 - Possible test enhancements
Summary: Possible test enhancements
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: low enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-22 06:27 UTC by Will Thompson
Modified: 2009-06-02 10:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Will Thompson 2009-04-22 06:27:42 UTC
match_jingle_action should be curried: almost every use is lambda e: jp.match_jingle_action(e.query, 'session-initiate') or similar.

Extract NewChannels-checking boilerplate.

Rename make_channel_proxy: wrap_channel should be used for channels, and the former only for SessionHandlers and StreamHandlers.
Comment 1 Will Thompson 2009-04-22 11:39:10 UTC
Done the second one in a branch; will rearrange patches and put it up for review at some point.
Comment 2 Will Thompson 2009-06-02 10:36:04 UTC
I never did finish extracting the NewChannels-checking boilerplate, but I did add a curried and flipped version of match_jingle_action, namely action_predicate.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.