Bug 2481 - Radeon driver build broken on systems with BuildXF86DRI NO
Summary: Radeon driver build broken on systems with BuildXF86DRI NO
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) OpenBSD
: high blocker
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-06 07:40 UTC by Matthieu Herrb
Modified: 2005-02-20 22:47 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Build log for drivers/ati/ (7.85 KB, text/plain)
2005-02-06 07:41 UTC, Matthieu Herrb
no flags Details
Proposed fix (3.13 KB, patch)
2005-02-18 07:21 UTC, Stephane Marchesin
no flags Details | Splinter Review
updated log (3.35 KB, text/plain)
2005-02-18 13:24 UTC, Matthieu Herrb
no flags Details
new version of the patch (2.90 KB, patch)
2005-02-18 14:55 UTC, Roland Scheidegger
no flags Details | Splinter Review

Description Matthieu Herrb 2005-02-06 07:40:56 UTC
The radeon driver fails to build in cvs HEAD from today 2005/2/6 when
BuildXF86DRI is set to NO. 
See attached log for details.
Comment 1 Matthieu Herrb 2005-02-06 07:41:58 UTC
Created attachment 1838 [details]
Build log for drivers/ati/
Comment 2 Matthieu Herrb 2005-02-18 05:56:01 UTC
no one seems to care ?
Comment 3 Alex Deucher 2005-02-18 06:12:35 UTC
This looks to be due to some of the new tiling stuff declared #if DRI that's
being used in non #if DRI code.  I may have time to look into this in the next
week or so.  I'll also let Roland and Stephane know as they wrote the tiling code.
Comment 4 Stephane Marchesin 2005-02-18 07:21:17 UTC
Created attachment 1933 [details] [review]
Proposed fix

Does this work for you ?
Comment 5 Matthieu Herrb 2005-02-18 13:24:52 UTC
Created attachment 1936 [details]
updated log

Better, but not fully ok.
Comment 6 Roland Scheidegger 2005-02-18 14:55:56 UTC
Created attachment 1940 [details] [review]
new version of the patch

does the new version of the patch work?
Comment 7 Antoine Jacoutot 2005-02-19 09:11:52 UTC
(In reply to comment #6)
> Created an attachment (id=1940) [edit]
> new version of the patch
> 
> does the new version of the patch work?

Yes it does. At least for me under OpenBSD-3.6-current on macppc.
Comment 8 Roland Scheidegger 2005-02-21 17:47:04 UTC
Fixed in cvs. btw sorry for the quite long initial delay, I guess I'd need to
watch the xorg-bugzilla-noise list too.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.