Bug 25711 - dbus-daemon reference in at-spi2-core/bus/at-spi-dbus-bus.in needs fully qualified path
Summary: dbus-daemon reference in at-spi2-core/bus/at-spi-dbus-bus.in needs fully qual...
Status: NEW
Alias: None
Product: at-spi2
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Mark Doffman
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-18 10:41 UTC by Willie Walker
Modified: 2010-01-14 03:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch that needs work (1.09 KB, patch)
2009-12-18 11:17 UTC, Willie Walker
Details | Splinter Review

Description Willie Walker 2009-12-18 10:41:22 UTC
The dbus module's configure.in file allows you to relocate the dbus-daemon:

...

AC_ARG_WITH(dbus_daemondir, AS_HELP_STRING([--with-dbus-daemondir=[dirname]],[Directory for installing the DBUS daemon]))

...

#### Directory to install dbus-daemon
if test -z "$with_dbus_daemondir" ; then
    DBUS_DAEMONDIR=$EXPANDED_BINDIR
else
    DBUS_DAEMONDIR=$with_dbus_daemondir
fi
AC_SUBST(DBUS_DAEMONDIR)
AC_DEFINE_UNQUOTED(DBUS_DAEMONDIR,"$DBUS_DAEMONDIR", [Directory for installing the DBUS daemon])

...

The default path seems to be /usr/bin, but we cannot depend upon that.  So, we probably need to do the same thing in at-spi2-core/configure.in and put a reference to @DBUS_DAEMONDIR@ in at-spi2-core/bus/at-spi-dbus-bus.in.


in at-spi2-core/bus/at-spi-dbus-bus.in, the
Comment 1 Willie Walker 2009-12-18 11:17:52 UTC
Created attachment 32179 [details] [review]
Patch that needs work

Here's a patch that needs work.  It's almost there -- the DBUS_DAEMONDIR=$bindir line needs the most work, I think.  $bindir needs to be fully expanded and it currently is not -- it's being set to ${exec_dir} or something like that.

Sorry to give you a half-a$$ed patch -- I just want to hammer something out before I left for break.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.