Bug 27048 - Does not compile with -DGSEAL_ENABLE
Summary: Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Alias: None
Product: libcanberra
Classification: Unclassified
Component: Unspecified (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Lennart Poettering
QA Contact:
URL:
Whiteboard:
Keywords: janitor
Depends on:
Blocks:
 
Reported: 2010-03-12 05:34 UTC by Andre Klapper
Modified: 2010-04-19 07:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Trivial patch (3.52 KB, patch)
2010-04-10 16:32 UTC, Andre Klapper
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Klapper 2010-03-12 05:34:05 UTC
libcanberra 0.23 does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

canberra-gtk-module.c: In function ‘dispatch_sound_event’:
canberra-gtk-module.c:453: error: ‘GtkObject’ has no member named ‘flags’
canberra-gtk-module.c:571: error: ‘GtkObject’ has no member named ‘flags’
canberra-gtk-module.c:642: error: ‘GtkMenuItem’ has no member named ‘submenu’
canberra-gtk-module.c: In function ‘emission_hook_cb’:
canberra-gtk-module.c:862: error: ‘GtkObject’ has no member named ‘flags’
canberra-gtk-module.c:862: error: ‘GtkObject’ has no member named ‘flags’
make[2]: *** [libcanberra_gtk_module_la-canberra-gtk-module.lo] Error 1
make[2]: Leaving directory `/home/andre/svn-gnome/libcanberra-0.23/src'
make[1]: *** [all-recursive] Error 1
Comment 1 Andre Klapper 2010-04-10 16:32:39 UTC
Created attachment 34883 [details] [review]
Trivial patch

Trivial patch. Bumps gtk+ requirement to 2.20 though (if I found the correct place to bump it in configure.ac).
Had some issues with compiling so no idea if this is a complete patch, but hope so.
Comment 2 Lennart Poettering 2010-04-19 07:57:22 UTC
Fixed in git now. Release follows shortly.
Comment 3 Lennart Poettering 2010-04-19 07:58:12 UTC
And thanks for the patch!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.