Bug 27626 - deadlock when registering application
Summary: deadlock when registering application
Status: RESOLVED FIXED
Alias: None
Product: at-spi2
Classification: Unclassified
Component: atk (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Rob Taylor
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-14 02:15 UTC by Li Yuan
Modified: 2010-05-28 04:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch (1.32 KB, application/octet-stream)
2010-04-14 02:17 UTC, Li Yuan 		Details
View All

Description Li Yuan 2010-04-14 02:15:15 UTC 
Now, atk-adaptor called dbus_connection_send_with_reply_and_block to register itself. This could cause deadlock if the application is gnome-session. When gnome-session is trying to register itself, at-spi2-registryd is also calling gnome-session through D-Bus for session management. But since gnome-session is blocked by dbus_connection_send_with_reply_and_block, deadlock happened.

The fix should avoid the "block" call.
Comment 1 Li Yuan 2010-04-14 02:17:59 UTC 
Created attachment 34995 [details]
patch
Comment 2 Li Yuan 2010-04-14 02:20:54 UTC 
I didn't use the reentry function in dbind because:
1. atk-adaptor is not link to dbind now.
2. warning messages may need to be printed during demarshal
Comment 3 Mike Gorse 2010-04-14 14:33:03 UTC 
This looks fine.
Comment 4 Stephen Shaw 2010-05-28 00:41:11 UTC 
It looks like this patch has already been applied to the code a couple months ago.  Can this be closed?
Comment 5 Li Yuan 2010-05-28 00:42:58 UTC 
Yes, I think so.
Comment 6 Mike Gorse 2010-05-28 04:45:55 UTC 
(In reply to comment #5)
> Yes, I think so.

Yes; this is committed. Closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.