Created attachment 35253 [details] [review] Proposed solution Since the connection lock is released for a short while in _dbus_connection_acquire_io_path there can already be a method return received by another thread. The fix is to do an extra check after the I/O path has been aquired both. This is possibly the same underlying problem as identified in: http://marc.info/?l=freedesktop-dbus&m=117323275932377&w=2 The patch was initially contributed to the Android project: http://review.source.android.com/#change,14121. We are hereby looking for input on the patch from the DBUS experts :)
Comment on attachment 35253 [details] [review] Proposed solution Patch looks good. I'll try and test later.
According to http://lists.freedesktop.org/archives/dbus/2010-May/012871.html these patch should be applied. Unfortunally the patch failed to apply error: patch failed: dbus/dbus-connection.c:2332 error: dbus/dbus-connection.c: patch does not apply Patch failed at 0001. Please update
(In reply to comment #2) > According to http://lists.freedesktop.org/archives/dbus/2010-May/012871.html > these patch should be applied. > > Unfortunally the patch failed to apply > > error: patch failed: dbus/dbus-connection.c:2332 > error: dbus/dbus-connection.c: patch does not apply > Patch failed at 0001. > > Please update Patch failed in dbus-1.2 and dbus-master branch. Please use the related branch for a rebase.
Created attachment 36176 [details] [review] original patch rebased to master
Created attachment 36177 [details] [review] original patch rebased to 1.2
patches are committed
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.