Bug 28351 - changing xv attributes have no effects on video playback in totem
Summary: changing xv attributes have no effects on video playback in totem
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 17:08 UTC by Hicham HAOUARI
Modified: 2010-10-19 19:45 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Hicham HAOUARI 2010-06-01 17:08:43 UTC
changing xv attributes ( XV_BRIGHTNESS, XV_CONTRAST, XV_HUE ... ) via xvattr have no effects on videos being played in totem

please let me know if you need any further information
Comment 1 Alex Deucher 2010-06-01 17:13:57 UTC
These attributes do not work when bicubic filtering is enabled.  Disable bicubic filtering to use the other xv attributes.  See the radeon man page for more info.

xvattr -a XV_BICUBIC -v 0
Comment 2 Hicham HAOUARI 2010-06-01 17:31:26 UTC
thanks a lot alex
Comment 3 Bastien Nocera 2010-06-02 03:23:38 UTC
How come XV_BICUBIC is enabled by default, when it makes all those settings useless?

Isn't it possible to disable the other settings when bicubic is enabled?
Comment 4 Bastien Nocera 2010-06-02 06:04:45 UTC
Reopening, as discussed with Jérôme.

Having bicubic filtering is nice, but it breaks all the user expectations when the brightness, contrast, etc. sliders offered by graphical applications fail to do anything.

Possible solutions include:
- Disabling bicubic filtering by default
- Only showing the colour correction values when bicubic scaling is disabled (I'm not sure whether that's possible with XVideo's interface, but my guess is not...)
- Implement colour correction even when bicubic filtering is selected.

The latter would obviously be the preferred way.
Comment 5 Michel Dänzer 2010-06-02 06:26:17 UTC
(In reply to comment #4)
> - Only showing the colour correction values when bicubic scaling is disabled
> (I'm not sure whether that's possible with XVideo's interface, but my guess is
> not...)

Indeed, I don't think so. However, it should be possible to disable bicubic filtering when the colour correction is not the identity.

> - Implement colour correction even when bicubic filtering is selected.
> 
> The latter would obviously be the preferred way.

Agreed, with the above alternative possibly being next in line, but certainly much easier to implement.
Comment 6 Alex Deucher 2010-06-02 09:35:24 UTC
Might be worth disabling bicubic by default due to this bug and bug 28114.  I'm not sure how motivated people are to fix this stuff on old chips.
Comment 7 Alex Deucher 2010-10-19 19:45:54 UTC
bicubic disabled by default.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.