There's this code in packagekit-background.cron:
# are we disabled?
if [ "$ENABLED" = "no" ]; then
We should not exit with 1 since this will trigger a mail, I think. We should just exit with 0 if we're disabled.
Isn't code zero exit code success? I admit also I don't know a tremendous amount about cron.
Yes, 0 is success. The thing is that packagekit-background.cron will be run daily anyway. If it's disabled, then the script just returns. If it returns 1, then a mail will be sent to the admin. If it returns 0, then nothing happens.
If the admin has disabled the script explicitly, we certainly don't want him to receive a mail to tell him so :-)
Makes sense. Please feel free to commit a fix straight to PK git master. Thanks!
Created attachment 37327 [details] [review]
Apparently, I can't push to master (not sure why), so here's the git patch.
Pushed to git master. Thanks!