Bug 29530 - Fix update notices: not all yum repos are official fedora ones
Summary: Fix update notices: not all yum repos are official fedora ones
Alias: None
Product: PackageKit
Classification: Unclassified
Component: backend-yum (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
Depends on:
Reported: 2010-08-12 06:02 UTC by Mark J Cox
Modified: 2010-08-27 15:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Proposed patch (1.49 KB, application/octet-stream)
2010-08-12 06:02 UTC, Mark J Cox
Proposed patch (1.49 KB, patch)
2010-08-12 06:14 UTC, Mark J Cox
Details | Splinter Review

Description Mark J Cox 2010-08-12 06:02:41 UTC
Created attachment 37812 [details]
Proposed patch

Currently a hardcoded link pointing to https://admin.fedoraproject.org/updates/ is added to all update notes that have an update_id.  But not all repositories providing updateinfo.xml data and id's are the upstream fedora repositories.  

Ideally the fedora repos would provide the link themselves in a references entity, and I'll add a bz for them to do that, but in the meantime the following patch ensures the link only gets added to updates from the official fedora repo by checking that the 'from' matches 'updates@feodraproject.org'.

I've also moved this logic before parsing other references as this vendor-specific URL is likely the most important (and self) reference.
Comment 1 Mark J Cox 2010-08-12 06:14:11 UTC
Created attachment 37813 [details] [review]
Proposed patch
Comment 2 Richard Hughes 2010-08-27 15:18:45 UTC
Committed, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.