Bug 35523 - Wrong parameter when calling to _atspi_dbus_call() from atspi_value_set_current_value
Summary: Wrong parameter when calling to _atspi_dbus_call() from atspi_value_set_curre...
Status: RESOLVED FIXED
Alias: None
Product: at-spi2
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Rob Taylor
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-21 15:21 UTC by Mario Sanchez Prada
Modified: 2011-03-21 15:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch to fix the issue (866 bytes, patch)
2011-03-21 15:23 UTC, Mario Sanchez Prada
Details | Splinter Review

Description Mario Sanchez Prada 2011-03-21 15:21:37 UTC
The current state of this call is like this:

 _atspi_dbus_call (obj, atspi_interface_value, "SetCurrentValue", error, "d", &d_new_value);

...where d_new_value is a double, so we're passing a reference instead of the value, which leads to passing the wrong data to the setter function.

Instead, it should be something like this:

 _atspi_dbus_call (obj, atspi_interface_value, "SetCurrentValue", error, "d", d_new_value);

Attaching the patch to fix this issue right after filing the bug
Comment 1 Mario Sanchez Prada 2011-03-21 15:23:52 UTC
Created attachment 44693 [details] [review]
Patch to fix the issue

Patch attached... doesn't look too complex :P
Comment 2 Mario Sanchez Prada 2011-03-21 15:49:50 UTC
Fixed! (reviewed by Mike Gorse)

http://git.gnome.org/browse/at-spi2-core/commit/?id=8ae8e84bed23c8bf7622c6442af93926853cd047


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.