Bug 36395 - gst-ffmpeg doesn't compile with GCC 4.6
Summary: gst-ffmpeg doesn't compile with GCC 4.6
Status: RESOLVED NOTOURBUG
Alias: None
Product: gstreamer
Classification: Unclassified
Component: account (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Thomas Vander Stichele
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 07:32 UTC by Marc Plano-Lesay
Modified: 2011-04-19 08:22 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch solving warnings (3.49 KB, patch)
2011-04-19 07:32 UTC, Marc Plano-Lesay
Details | Splinter Review

Description Marc Plano-Lesay 2011-04-19 07:32:02 UTC
gst-ffmpeg fails to compile due to unused but set warnings. The attached patch corrects every warning, but I've got a doubt about deleting this:

@@ -321,8 +320,6 @@ gst_ffmpegscale_transform_caps (GstBaseTransform * trans,
   /* this function is always called with a simple caps */
   g_return_val_if_fail (GST_CAPS_IS_SIMPLE (caps), NULL);
 
-  scale = GST_FFMPEGSCALE (trans);
-

(the scale returned is never used)
Comment 1 Marc Plano-Lesay 2011-04-19 07:32:29 UTC
Created attachment 45819 [details] [review]
Patch solving warnings
Comment 2 Tim Müller 2011-04-19 08:22:17 UTC
Hi, thanks for the bug report and patch.

We don't use bugs.freedesktop.org for bug tracking (only for git account requests), our bug tracker is at gnome.org, see http://gstreamer.freedesktop.org/bugs/ .

However, I've pushed this now, no need to refile it there.

commit 9c42b7cae9d4f114eee2b7f920900c6f2acf24e6
Author: Marc Plano-Lesay <marc.planolesay@gmail.com>
Date:   Tue Apr 19 16:26:55 2011 +0200

    Fix unused-but-set-variable warnings with gcc 4.6


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.