Bug 4208 - cleanup of issues reported by sparse
Summary: cleanup of issues reported by sparse
Status: RESOLVED FIXED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: 0.1.3
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Billy Biggs
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-23 05:04 UTC by Kjartan Maraas
Modified: 2005-08-29 03:08 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
patch for warnings (12.48 KB, patch)
2005-08-23 05:05 UTC, Kjartan Maraas 		Details | Splinter Review
Patch applied to xserver (6.56 KB, patch)
2005-08-27 19:37 UTC, Billy Biggs 		Details | Splinter Review
View All

Description Kjartan Maraas 2005-08-23 05:04:46 UTC 
This patch fixes some warnings from sparse.

- 0 vs. NULL
- mixed code and declarations
- missing static
Comment 1 Kjartan Maraas 2005-08-23 05:05:08 UTC 
Created attachment 3005 [details] [review]
patch for warnings
Comment 2 Owen Taylor 2005-08-23 05:22:55 UTC 
Fixed the two non-libpixman issues; reassigning to libpixman

2005-08-23  Owen Taylor  <otaylor@redhat.com>

        Some fixes for warnings from sparse (Part of #4208,
        Kjartan Maraas)

        * test/cairo-test.c (create_xlib_surface): Use NULL, not 0.

        * src/cairo-matrix.c (_cairo_matrix_transformed_circle_major_axis):
        Fix C99'ism of mixed code and declarations.
Comment 3 Billy Biggs 2005-08-23 07:54:27 UTC 
This cannot be made static since it is referred to from fbmmx.c when MMX support
is compiled in.

-FbComposeFunctions composeFunctions = {
+static FbComposeFunctions composeFunctions = {
Comment 4 Billy Biggs 2005-08-27 19:37:48 UTC 
Created attachment 3070 [details] [review]
Patch applied to xserver
Comment 5 Billy Biggs 2005-08-27 19:38:44 UTC 
I fixed the ones in libpixman and changed xserver as appropriate.  Thanks!
Comment 6 Eric Anholt 2005-08-29 20:08:43 UTC 
The xserver patch has also been applied to xorg.  Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.