Bug 4231 - More vendor string differences
Summary: More vendor string differences
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: xlib backend (show other bugs)
Version: 0.9.3
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-24 20:31 UTC by Billy Biggs
Modified: 2005-08-27 01:49 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
My preferred fix (779 bytes, patch)
2005-08-24 20:33 UTC, Billy Biggs
Details | Splinter Review

Description Billy Biggs 2005-08-24 20:31:08 UTC
Today on IRC I was talking to a gentoo user who had the same broken nautilus
rendering problems that were fixed by bug 4068.  Their X server was still a
4.3.0 version:

name of display:    :0.0
version number:    11.0
vendor string:    Gentoo Linux (XFree86 4.3.0, revision r5)
vendor release number:    40300001
XFree86 version: 4.3.0.1

Note the vendor string.  I find it interesting to note that xdpyinfo.c from X
only checks for strstr("XFree86").  Why not use that method instead of looking
for the entire string?
Comment 1 Billy Biggs 2005-08-24 20:33:35 UTC
Created attachment 3025 [details] [review]
My preferred fix
Comment 2 Owen Taylor 2005-08-27 18:49:48 UTC
2005-08-27  Owen Taylor  <otaylor@redhat.com>

        * src/cairo-xlib-surface.c (_cairo_xlib_surface_create_internal):
        Make the vendor string check for XFree86 more liberal, to deal
        with older versions of gentoo that modified it in a different
        way. (#4231, fix from Billy Biggs)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.