Bug 45180 - [PATCH] build patches
Summary: [PATCH] build patches
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Shared Mime Info group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 07:26 UTC by Colin Walters
Modified: 2012-01-24 09:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
See patch (934 bytes, patch)
2012-01-24 07:26 UTC, Colin Walters
Details | Splinter Review
autogen (766 bytes, patch)
2012-01-24 07:26 UTC, Colin Walters
Details | Splinter Review
Allow builders to not run make check by default (1.59 KB, patch)
2012-01-24 09:06 UTC, Colin Walters
Details | Splinter Review

Description Colin Walters 2012-01-24 07:26:22 UTC
Created attachment 56083 [details] [review]
See patch

See attached.
Comment 1 Colin Walters 2012-01-24 07:26:39 UTC
Created attachment 56084 [details] [review]
autogen
Comment 2 Bastien Nocera 2012-01-24 07:33:55 UTC
Comment on attachment 56084 [details] [review]
autogen

Pushed.
Comment 3 Colin Walters 2012-01-24 09:06:48 UTC
Created attachment 56091 [details] [review]
Allow builders to not run make check by default
Comment 4 Bastien Nocera 2012-01-24 09:14:29 UTC
commit 668361327d47ab6e50e407e54f3e236aa3ed611f
Author: Colin Walters <walters@verbum.org>
Date:   Tue Jan 24 10:52:00 2012 -0500

    Allow builders to not run make check by default
    
    Doing so breaks cross compilation, and is just plain different from
    pretty much every other module out there in the GNOME dependency stack.
    
    Furthermore, the environment needed for tests is not necessarily the
    same as that needed to just do a build.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=45180


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.