Bug 46794 - gnome-shell does not show correct user name or profile picture
Summary: gnome-shell does not show correct user name or profile picture
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 13:20 UTC by Giovanni Campagna
Modified: 2012-03-15 16:41 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
UserManager: fix advancing seat loading state machine (2.92 KB, patch)
2012-02-29 13:21 UTC, Giovanni Campagna
Details | Splinter Review
ActUser: set loaded status even if an error occurs (1.11 KB, patch)
2012-02-29 13:21 UTC, Giovanni Campagna
Details | Splinter Review
ActUser: use -1 to indicate default DBus timeout (1.05 KB, patch)
2012-02-29 13:22 UTC, Giovanni Campagna
Details | Splinter Review

Description Giovanni Campagna 2012-02-29 13:20:54 UTC
Ok, that was the net outcome. After some analysis, I found three small bugs in libaccountsservice, in how the state machine for is-loaded is advanced as data arrives from the bus.
I hope that the patches are clear enough. They fix the visibile part of the bug here.
Comment 1 Giovanni Campagna 2012-02-29 13:21:40 UTC
Created attachment 57828 [details] [review]
UserManager: fix advancing seat loading state machine

Because the session proxy creating happened synchronously, seat
loading state was incremented, but nothing called load_seat_incrementally()
again, meaning that it never advanced to next step. Making it async
like the other operations fixes it.
Comment 2 Giovanni Campagna 2012-02-29 13:21:53 UTC
Created attachment 57829 [details] [review]
ActUser: set loaded status even if an error occurs

Not doing so confuses the UserManager, which still considers the
user pending and blocks the emission of user-added/user-removed
signals.
Comment 3 Giovanni Campagna 2012-02-29 13:22:03 UTC
Created attachment 57830 [details] [review]
ActUser: use -1 to indicate default DBus timeout

Passing 0 means 0 milliseconds, which is quite too short even on
modern computers.
Comment 4 Ray Strode [halfline] 2012-03-15 16:41:15 UTC
Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.