47742 – [softpipe] piglit fbo-generatemipmap-array regression

Bug 47742 - [softpipe] piglit fbo-generatemipmap-array regression

Summary: [softpipe] piglit fbo-generatemipmap-array regression

Status:	RESOLVED FIXED

Alias:	None

Product:	Mesa
Classification:	Unclassified
Component:	Other (show other bugs)
Version:	git
Hardware:	x86-64 (AMD64) Linux (All)

Importance:	medium normal
Assignee:	mesa-dev
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-03-22 21:51 UTC by Vinson Lee
Modified:	2012-03-23 09:10 UTC (History)
CC List:	1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Vinson Lee 2012-03-22 21:51:39 UTC

mesa: 8d9decb75f0df564abaf9888d9fc5c77de8059cd (master)

$ ./bin/fbo-generatemipmap-array -auto
Probe at (1,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (130,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (195,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (228,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (245,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (254,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (259,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (1,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (130,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (195,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (228,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (245,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (254,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (259,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (1,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (130,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (195,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (228,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (245,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (254,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (259,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (1,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (130,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (195,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (228,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (245,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (254,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (259,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (270,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (399,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (464,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (497,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (514,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (523,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (528,1)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (270,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (399,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (464,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (497,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (514,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (523,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (528,134)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (270,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (399,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (464,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (497,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (514,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (523,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (528,267)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (270,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (399,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (464,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (497,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (514,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (523,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (528,400)
  Expected: 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
PIGLIT: {'result': 'fail' }

Comment 1 Vinson Lee 2012-03-22 23:32:54 UTC

d335e69b9ab8b3068dc402e22e49483f9caab1df is the first bad commit
commit d335e69b9ab8b3068dc402e22e49483f9caab1df
Author: Brian Paul <brianp@vmware.com>
Date:   Sat Mar 17 16:30:03 2012 -0600

    mesa: rewrite/consolidate code in _mesa_test_texobj_completeness()
    
    Merge the mipmap level checking code that was separate cases for 1D,
    2D, 3D and CUBE before.
    
    Reviewed-by: José Fonseca <jfonseca@vmware.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>

Comment 2 Jose Fonseca 2012-03-23 00:14:00 UTC

I took another look at the commit, and now noticed numFaces is never set to 6 for cube maps.

Perhaps the test or mipmap generation is relying on texture to not be complete.

Comment 3 Brian Paul 2012-03-23 06:56:04 UTC

(In reply to comment #2)
> I took another look at the commit, and now noticed numFaces is never set to 6
> for cube maps.

Good catch.  I guess we don't have any tests that exercise incomplete cube maps.  I'll fix that.

 
> Perhaps the test or mipmap generation is relying on texture to not be complete.

It looks like the bug is in the state tracker's gen-mipmap code.  I don't know why this wasn't a problem sooner.  I'll have a patch in a bit.

Comment 4 Brian Paul 2012-03-23 09:10:25 UTC

Fixed with commit 318669f196ca922337da02af9d72773e76e70b45

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.