Bug 53376 - Fix some globs for OGG files
Summary: Fix some globs for OGG files
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Shared Mime Info group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-11 12:01 UTC by Luca Wehrstedt
Modified: 2013-09-30 08:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Proposed patch (2.10 KB, patch)
2012-08-11 12:01 UTC, Luca Wehrstedt
Details | Splinter Review

Description Luca Wehrstedt 2012-08-11 12:01:50 UTC
Created attachment 65425 [details] [review]
Proposed patch

Use both *.ogg and *.oga for audio/ogg and both *.ogg and *.ogv for
video/ogg. Also, use *.spx only for audio/x-speex.

I'm attaching a patch.
Comment 1 Bastien Nocera 2012-09-24 10:50:54 UTC
commit b3e64e0b5e5b44e8d9fa2d7fce1688b28c3e90e5
Author: Luca Wehrstedt <lerks@users.sourceforge.net>
Date:   Sat Aug 11 12:20:45 2012 +0200

    Fix some globs for OGG files
    
    Use both *.ogg and *.oga for audio/ogg and both *.ogg and *.ogv for
    video/ogg. Also, use *.spx only for audio/x-speex.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=53376
Comment 2 David Faure 2013-06-11 11:48:03 UTC
Having *.ogv for both video/ogg and video/x-theora+ogg creates problems:
ogv files are now determined from their contents rather than from their extension, and this is known to be unreliable with OGG containers, we actually get "audio/ogg" as a result for some video files.

My colleague Eike Hein who looked into it, said:
"An Ogg video is *commonly* Vorbis for audio and Theora for video, but not necessarily; mapping exists for the bitstreams of other codecs (e.g. VP8). IOW claiming Theora feels wrong to me unless the MIME magic can actually detect Theora in there (e.g. by checking the FOURCC)."

So it seems to me that *.ogv should be removed from video/x-theora+ogg, as a result of this commit which associates it with a more generic (and more correct) mimetype.
Comment 3 Bastien Nocera 2013-09-30 08:32:14 UTC
commit 7978a04f5b61f9e3b329056e65778a4ccbd8253c
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Sep 30 10:30:49 2013 +0200

    Remove *.ogv as a glob for Theora videos
    
    As we can't be certain that it is actually Theora video (could be
    VP8 video as well). *.ogv is still associated with the more generic
    video/ogg mime-type.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=53376


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.