Bug 53742 - Build: Do not try to discover and use gtk-builder-convert
Summary: Build: Do not try to discover and use gtk-builder-convert
Status: RESOLVED MOVED
Alias: None
Product: SyncEvolution
Classification: Unclassified
Component: GTK UI (show other bugs)
Version: unspecified
Hardware:
: medium normal
Assignee: SyncEvolution Community
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-30 09:06 UTC by SyncEvolution Community
Modified: 2018-10-13 12:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
0001-Do-not-check-for-or-use-gtk-builder-convert.patch (deleted)
2011-06-30 09:06 UTC, SyncEvolution Community
Details | Splinter Review
0001-Do-not-check-for-libglade-because-it-is-not-used.patch (deleted)
2011-06-30 09:14 UTC, SyncEvolution Community
Details | Splinter Review

Description Patrick Ohly 2012-08-19 18:56:45 UTC


---- Reported by murrayc@murrayc.com 2011-06-30 09:06:31 +0000 ----

Created attachment 7722 [details] [review]
0001-Do-not-check-for-or-use-gtk-builder-convert.patch

gtk-builder-convert is really not something that should be used in a build process. It should be for one-time conversion and then not used again. And the build has no need to have both file formats anyway because it only uses GtkBuilder format.

Keeping the libglade-format file requires people to edit that one, risking new failures during the automatic conversion. I'm not sure if recent versions of Glade even save in libglade format any more.

This will fix this Maemo build issue, though it's not important:
https://bugs.maemo.org/show_bug.cgi?id=7466



---- Additional Comments From murrayc@murrayc.com 2011-06-30 09:14:07 +0000 ----

Created attachment 7723 [details] [review]
0001-Do-not-check-for-libglade-because-it-is-not-used.patch

And this additional patch removes the useless check for libglade.



---- Additional Comments From jku@linux.intel.com 2011-06-30 11:41:51 +0000 ----

Yeah this is very much true. There was a reason for this -- bug in glade IIRC but that was a loong time ago.



---- Additional Comments From patrick.ohly@gmx.de 2011-06-30 17:05:56 +0000 ----

Looks like a useful fix, but let's keep master stable and thus add it after the 1.2 release.



--- Bug imported by patrick.ohly@gmx.de 2012-08-19 20:56 UTC  ---

This bug was previously known as _bug_ 20370 at https://bugs.meego.com/show_bug.cgi?id=20370
Imported an attachment (id=65795)
Imported an attachment (id=65796)

Unknown platform unknown. Setting to default platform "".
Unknown operating system unknown. Setting to default OS "".

Comment 1 GitLab Migration User 2018-10-13 12:40:56 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/SyncEvolution/syncevolution/issues/52.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.