Bug 54418 - Fix autoconf tests on OpenBSD
Summary: Fix autoconf tests on OpenBSD
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All OpenBSD
: medium normal
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-03 06:49 UTC by Brad Smith
Modified: 2012-09-03 09:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
autoconf patch (815 bytes, patch)
2012-09-03 06:49 UTC, Brad Smith
Details | Splinter Review

Description Brad Smith 2012-09-03 06:49:11 UTC
Created attachment 66528 [details] [review]
autoconf patch

The attached patch fixes two autoconf tests so they will work properly on OpenBSD. sys/socket.h needs to include sys/types.h.
Comment 1 Simon McVittie 2012-09-03 09:24:36 UTC
Thanks, fixed in git for 1.6.6 and 1.7.0 by applying your patch without changes.

I consider this to be a workaround for an OpenBSD bug, but it's easy enough to work around.

If you're an OpenBSD developer I would encourage you to make the public headers include their own dependencies (possibly by using private headers like glibc does), so that the obvious usage becomes correct, and you won't have to keep patching projects that are mainly tested on GNU.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.