AES2501 driver needs some image improvements: * image contrast is not as good as on AES2550 * driver stops scan immediately after empty frame was received, but sometimes we get empty frames in the middle of scan
Created attachment 69484 [details] [review] 0001-AES2501-wait-for-3-empty-frames-to-stop-scan.patch
Created attachment 69485 [details] [review] 0002-AES2501-improve-image-contrast.patch
Created attachment 69487 [details] [review] 0003-AES2501-Update-copyright-line.patch Not an improvement, but AES2501-related
Comment on attachment 69484 [details] [review] 0001-AES2501-wait-for-3-empty-frames-to-stop-scan.patch Review of attachment 69484 [details] [review]: ----------------------------------------------------------------- Looks good.
Comment on attachment 69485 [details] [review] 0002-AES2501-improve-image-contrast.patch Review of attachment 69485 [details] [review]: ----------------------------------------------------------------- Looks good.
Comment on attachment 69487 [details] [review] 0003-AES2501-Update-copyright-line.patch Review of attachment 69487 [details] [review]: ----------------------------------------------------------------- Looks good otherwise. ::: libfprint/drivers/aes2501.c @@ +2,4 @@ > * AuthenTec AES2501 driver for libfprint > * Copyright (C) 2007-2008 Daniel Drake <dsd@gentoo.org> > * Copyright (C) 2007 Cyrille Bagard > + * Copyright (C) 2007-2012 Vasily Khoruzhick <anarsoul@gmail.com> You didn't touch the driver between 2007 and 2012, so it should be: Copyright (C) 2007, 2012 Vasily Khoruzhick <anarsoul@gmail.com> instead.
(In reply to comment #6) > You didn't touch the driver between 2007 and 2012, so it should be: > Copyright (C) 2007, 2012 Vasily Khoruzhick <anarsoul@gmail.com> > instead. There was one patch in 2008, see 40e7ac195a4be0e6951b7a8b0388bdbc88cfc8d7 So I think 2007-2008, 2012 would be fair
commit fecf6d6fe5d17f4d0cb5cc8e19d0f51c58fcc712 Author: Vasily Khoruzhick <anarsoul@gmail.com> Date: Sat Nov 3 16:29:51 2012 +0300 aes2501: Update copyright line https://bugs.freedesktop.org/show_bug.cgi?id=56715 commit e32fa8cc3825a6ce5db558094e81134d433293e3 Author: Vasily Khoruzhick <anarsoul@gmail.com> Date: Sat Nov 3 16:13:05 2012 +0300 aes2501: Improve image contrast When scanning, check the histogram sum, and increase the ADREFHI register value if the sum is too low, or decrease it if it's too high. https://bugs.freedesktop.org/show_bug.cgi?id=56715 commit d8aae30a672485de747e5a58ff7520128b718515 Author: Vasily Khoruzhick <anarsoul@gmail.com> Date: Sat Nov 3 16:08:04 2012 +0300 aes2501: Harden against low finger pressure Wait for 3 empty frames before stopping the scan The driver used to stop the scan immediately after an empty frame (by checking for hist sum == 0), but it is possible to get empty frames in the middle of the scan due to low finger pressure. Waiting for 3 empty frames stop the driver wrongly aborting the scan too early. https://bugs.freedesktop.org/show_bug.cgi?id=56715
commit 9e10edd422e5130e210e17d90c5db9135029f165 Author: Bastien Nocera <hadess@hadess.net> Date: Mon Nov 5 19:52:46 2012 +0100 aes2501: Add year 2008 to the copyright. https://bugs.freedesktop.org/show_bug.cgi?id=56715#c7
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.