Created attachment 253 [details] [review]
Prototype patch for 2004-04-30-trunk

The patch still has the following flags:
- There is no dialog to select a printer and/or printer attributes (page size
etc.-)
- The Xrm resource counterpart for XPSERVERLIST isn't honored
- In |CreatePrintShell()| there is something I do not understand:
-- snip --
+
+    /* XXX: Why is the |dummyc|&&|dummys| stuff needed here ? */
+    XtDisplayInitialize(XtWidgetToApplicationContext(videoshell), pdpy,
+			 videoname, videoclass,
+			 NULL, 0,
+			 &dummyc, &dummys);
+
-- snip --
Why are these |dummy*|-args required ?

- Another possible problem hides in |PrintEndJobCB|:
-- snip --
+static
+void PrintEndJobCB(Widget pshell, XtPointer client_data, XtPointer call_data)
+{
+    AppPrintData *p = (AppPrintData *)client_data;
+
+    Log(("--> PrintEndJobCB\n"));
+
+    /* XXX: Is it legal that a print shell widget can destroy itself from
+     * within it's own callback ? */
+    FinishPrinting(p);
+}
-- snip --
Is it legal that |FinishPrinting()| will destroy the xawPrintShell widget
object where the callback is called for (in C++ it's legal but you MUST not
touch any member of that (dead) object after that point...)) ?

s/The patch still has the following flags/The patch still has the following
flaws/

Created attachment 279 [details] [review]
Patch for 2004-05-09-trunk

More or less final patch... I'll forward the implementation of a print dialog
to a new bug.

Patch checked-in...

Checking in xc/ChangeLog;
/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.22; previous revision: 1.21
done
Checking in xc/programs/xlogo/Imakefile;
/cvs/xorg/xc/programs/xlogo/Imakefile,v  <--  Imakefile
new revision: 1.3; previous revision: 1.2
done
Checking in xc/programs/xlogo/XLogo.ad;
/cvs/xorg/xc/programs/xlogo/XLogo.ad,v  <--  XLogo.ad
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvs/xorg/xc/programs/xlogo/print.c,v
done
Checking in xc/programs/xlogo/print.c;
/cvs/xorg/xc/programs/xlogo/print.c,v  <--  print.c
initial revision: 1.1
done
RCS file: /cvs/xorg/xc/programs/xlogo/print.h,v
done
Checking in xc/programs/xlogo/print.h;
/cvs/xorg/xc/programs/xlogo/print.h,v  <--  print.h
initial revision: 1.1
done
Checking in xc/programs/xlogo/xlogo.c;
/cvs/xorg/xc/programs/xlogo/xlogo.c,v  <--  xlogo.c
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvs/xorg/xc/programs/xlogo/xlogo.h,v
done
Checking in xc/programs/xlogo/xlogo.h;
/cvs/xorg/xc/programs/xlogo/xlogo.h,v  <--  xlogo.h
initial revision: 1.1
done
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED.