Bug 58466 - Fix login history variant handling
Summary: Fix login history variant handling
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 15:37 UTC by Giovanni Campagna
Modified: 2012-12-18 20:20 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch (1.87 KB, patch)
2012-12-18 15:41 UTC, Giovanni Campagna
Details | Splinter Review

Description Giovanni Campagna 2012-12-18 15:37:41 UTC
g_variant_compare() returns 0 when the values are equal, and non-zero
otherwise, which is the opposite of what the check wants.
Also, it is valid for the login history variant to be null, when the
library is working with an older daemon. Don't emit a critical in that
case.
Comment 1 Giovanni Campagna 2012-12-18 15:41:17 UTC
Created attachment 71736 [details] [review]
Patch

Ghgh, git-bz is not working...
Comment 2 Ray Strode [halfline] 2012-12-18 20:20:06 UTC
pushed


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.