Bug 59320 - Add support for 147e:2020
Summary: Add support for 147e:2020
Status: RESOLVED FIXED
Alias: None
Product: libfprint
Classification: Unclassified
Component: libfprint (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: libfprint-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-13 13:58 UTC by Vasily Khoruzhick
Modified: 2013-06-26 08:25 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
0001-configure.ac-use-AC_CONFIG_HEADERS.patch (812 bytes, patch)
2013-01-13 13:59 UTC, Vasily Khoruzhick
Details | Splinter Review
0002-upeke2-add-147e-2020-IDs.patch (1.44 KB, patch)
2013-01-13 14:00 UTC, Vasily Khoruzhick
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Vasily Khoruzhick 2013-01-13 13:58:53 UTC

    
Comment 1 Vasily Khoruzhick 2013-01-13 13:59:31 UTC
Created attachment 72959 [details] [review]
0001-configure.ac-use-AC_CONFIG_HEADERS.patch
Comment 2 Vasily Khoruzhick 2013-01-13 14:00:22 UTC
Created attachment 72960 [details] [review]
0002-upeke2-add-147e-2020-IDs.patch
Comment 3 Bastien Nocera 2013-01-13 17:01:19 UTC
Comment on attachment 72959 [details] [review]
0001-configure.ac-use-AC_CONFIG_HEADERS.patch

Review of attachment 72959 [details] [review]:
-----------------------------------------------------------------

Looks good.
Comment 4 Bastien Nocera 2013-01-13 17:12:24 UTC
Comment on attachment 72960 [details] [review]
0002-upeke2-add-147e-2020-IDs.patch

Review of attachment 72960 [details] [review]:
-----------------------------------------------------------------

Looks good too. Do you have a git account yet?

::: libfprint/drivers/upeke2.c
@@ +854,3 @@
>  static int discover(struct libusb_device_descriptor *dsc, uint32_t *devtype)
>  {
>  	/* Revision 2 is what we're interested in */

You can remove that comment I guess.
Comment 5 Vasily Khoruzhick 2013-01-13 17:20:47 UTC
(In reply to comment #4)
> Comment on attachment 72960 [details] [review] [review]
> 0002-upeke2-add-147e-2020-IDs.patch
> 
> Review of attachment 72960 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> Looks good too. Do you have a git account yet?

Nope, see https://bugs.freedesktop.org/show_bug.cgi?id=56860
 
> ::: libfprint/drivers/upeke2.c
> @@ +854,3 @@
> >  static int discover(struct libusb_device_descriptor *dsc, uint32_t *devtype)
> >  {
> >  	/* Revision 2 is what we're interested in */
> 
> You can remove that comment I guess.

Yep, code is self-descriptive.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.