Created attachment 74136 [details]
Patch to implement getDatabases in ActiveSync
The attached patch implements getDatabases in the ActiveSync backend. This patch just lists the folders, it does not add support for specifying a folder name in the sync. However, the user can use this information to work out which collection ID to specify in the sync.
This depends on the eas_sync_handler_get_folder_list function in libeasclient created by the patch in bug #60204.
Oops, I posted the wrong patch. Please ignore the first attachment. I will add a new one in a moment.
Created attachment 74139 [details] [review]
Updated patch for getDatabases in ActiveSync
(In reply to comment #2)
> Created attachment 74139 [details] [review] [review]
> Updated patch for getDatabases in ActiveSync
Looks good, except for some minor coding style nitpicking.
* please indent by four spaces
* mixed case instead of underscores:
m_folder_paths -> m_folderPaths
get_collection_path -> getCollectionPath
Please include a commit message in the patch and use "git format-patch".
Created attachment 74199 [details] [review]
New patch, from git-format-patch
I have fixed the style issues, I think, I also decided that the static functions should become methods of the Collection nested object, which I think is neater.
Commit message added and git-format-patch output attached.
I've included the patch in a test branch and will run it through the automated testing once before merging into master.
Patch included in master branch, with one minor improvement:
Author: Patrick Ohly <email@example.com>
Date: Wed Feb 27 06:46:17 2013 -0800
ActiveSync: avoid explicit g_object_unref for EasSyncHandler
Better use a smart pointer - less code and harder to make mistakes.