Bug 62586 - checks for systemd, not for logind
Summary: checks for systemd, not for logind
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
Depends on:
Reported: 2013-03-21 11:40 UTC by Martin Pitt
Modified: 2013-04-06 22:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Check for logind, not for systemd (4.91 KB, patch)
2013-03-21 11:56 UTC, Martin Pitt
Details | Splinter Review

Description Martin Pitt 2013-03-21 11:40:55 UTC
accountsservice talks to logind, but actually checks for systemd with sd_booted(). It is possible to build systemd without logind, in which case sd_booted() would still succeed(), but the various sd_pid_get_* would fail.

For running systemd init without logind, or for running logind without systemd init we need to change the check to test for logind.

For details, see [1] if you are interested.

[1] https://mail.gnome.org/archives/desktop-devel-list/2013-March/msg00092.html
Comment 1 Martin Pitt 2013-03-21 11:56:26 UTC
Created attachment 76861 [details] [review]
Check for logind, not for systemd
Comment 2 Matthias Clasen 2013-04-03 17:33:42 UTC
Comment on attachment 76861 [details] [review]
Check for logind, not for systemd

Review of attachment 76861 [details] [review]:

sure, looks fine
Comment 3 Martin Pitt 2013-04-04 03:42:39 UTC
Thanks for the review! I cannot push to accountsservice myself, FTR.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.