Bug 65649 - act-user-manager might set "is-loaded" before loading is complete.
Summary: act-user-manager might set "is-loaded" before loading is complete.
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-11 12:40 UTC by Marius Vollmer
Modified: 2013-06-30 18:25 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Don't set "is-loaded" prematurely. (1.08 KB, patch)
2013-06-11 12:40 UTC, Marius Vollmer
Details | Splinter Review

Description Marius Vollmer 2013-06-11 12:40:47 UTC
Created attachment 80685 [details] [review]
Don't set "is-loaded" prematurely.

When load_seat_incrementally is called from load_idle, it might call maybe_set_is_loaded immediately.  This will set "is-loaded" even though load_users hasn't been called yet.

One path is

 load_idle
 load_seat_incrementally
 get_current_session_id
 _get_current_systemd_session_id
 unload_seat
 maybe_set_is_loaded

One fix is to interchange the calls to load_seat_incrementally and load_users in load_idle.  Maybe that's too subtle...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.