Bug 70367 - Add keyboard backlight save/restore
Summary: Add keyboard backlight save/restore
Status: RESOLVED FIXED
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: systemd-bugs
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-11 07:47 UTC by Bastien Nocera
Modified: 2013-10-11 11:00 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Add support for saving/restoring keyboard backlights (2.64 KB, patch)
2013-10-11 07:48 UTC, Bastien Nocera
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bastien Nocera 2013-10-11 07:47:48 UTC
Similarly to the screen backlight save and restore, we should make it possible to save and restore keyboard backlight levels.
Comment 1 Bastien Nocera 2013-10-11 07:48:17 UTC
Created attachment 87429 [details] [review]
Add support for saving/restoring keyboard backlights

Piggy-backing on the display backlight code, this saves and restores
keyboard backlights on supported devices.

The detection code matches that of UPower:
http://cgit.freedesktop.org/upower/tree/src/up-kbd-backlight.c#n173

NOTE: Untested.
Comment 2 Tom Gundersen 2013-10-11 11:00:17 UTC
Thanks for the patch.

I applied it with a minor change: the matching on the kernel name was a bit too strict for some keyboard backlight devices (I could find at least "{samsung,asus,smc}::kbd_backlight" in the kernel).

Please check that this makes sense for you: http://cgit.freedesktop.org/systemd/systemd/commit/?id=1a0464230c08506c3fd715ff7cc56660df3a85ca


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.