Bug 70770 - Dependency on glib 2.38 could be relaxed
Summary: Dependency on glib 2.38 could be relaxed
Status: RESOLVED NOTABUG
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 15:45 UTC by Marius Vollmer
Modified: 2014-10-10 10:38 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Relax glib dependency by making extensions optional. (1.55 KB, text/plain)
2013-10-22 15:45 UTC, Marius Vollmer
Details

Description Marius Vollmer 2013-10-22 15:45:04 UTC
Created attachment 88006 [details]
Relax glib dependency by making extensions optional.

Relaxing the dependency on glib would allow accountsservice 0.6.35 to more easily enter conservative places like RHEL.

The attached patch does this by effectively disabling extensions.  We can probably avoid that by implementing the Properties interface from scratch, but I think that is overkill.  We can probably tolerate not having support for extensions until glib has been updated as well.
Comment 1 Matthias Clasen 2013-10-22 16:10:56 UTC
looks ok to me
Comment 2 Ray Strode [halfline] 2013-10-23 13:03:32 UTC
Not sure.  I mean, distros that want to use it can patch out the functionality easily enough.

We did that in Fedora here:

http://pkgs.fedoraproject.org/cgit/accountsservice.git/commit/?h=f19&id=0ea0db4a4d6c71c33fc531ec64882caf538bb4b9

The problem with these types of #ifdef's is is they tend to build up over time and not get cleaned up later.

Anyway, i'm pretty strongly on the fence on this one.  If you guys both feel like it's the way to go, i'm not going to stand in the way.
Comment 3 Marius Vollmer 2013-10-23 16:27:24 UTC
(In reply to comment #2)
> Not sure.  I mean, distros that want to use it can patch out the
> functionality easily enough.

Yes, I can't really argue against this.  It's easy enough for distributions to carry a patch like this.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.