Bug 73455 - autotools compile problem
Summary: autotools compile problem
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: Havoc Pennington
QA Contact:
Depends on:
Reported: 2014-01-09 22:04 UTC by Ralf Habacker
Modified: 2014-01-10 14:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Fix compile error (754 bytes, patch)
2014-01-10 13:52 UTC, Ralf Habacker
Details | Splinter Review

Description Ralf Habacker 2014-01-09 22:04:09 UTC
With dbus master and activated systemd support I got the following problem when compiling on opensuse 12.2 x64

make[2]: Entering directory `/home/ralf/src/dbus-autotools-build/dbus'
  CC       libdbus_internal_la-dbus-spawn.lo
../../dbus/dbus/dbus-spawn.c: In function '_dbus_spawn_async_with_babysitter':
../../dbus/dbus/dbus-spawn.c:1299:52: error: 'LOG_INFO' undeclared (first use in this function)
../../dbus/dbus/dbus-spawn.c:1299:52: note: each undeclared identifier is reported only once for each function it appears in
../../dbus/dbus/dbus-spawn.c:1300:52: error: 'LOG_WARNING' undeclared (first use in this function)
make[2]: *** [libdbus_internal_la-dbus-spawn.lo] Fehler 1
make[2]: Leaving directory `/home/ralf/src/dbus-autotools-build/dbus'

dbus-spawn.c includes /usr/include/systemd/sd-journal.h, which defines sd_journal_stream_fd, but not the related p. 
reprocessor constants
Comment 1 Simon McVittie 2014-01-10 13:41:52 UTC
I'm not sure why I don't see this myself - different systemd or libc versions, probably.

Yes, any file that uses LOG_foo should include syslog.h. syslog.h is not 100% portable (I don't think Android has it) so we should put it inside the #ifdef HAVE_SYSTEMD - it seems reasonable to assume that systemd will continue to support only "normal" GNU/Linux, and not weird Linux-based environments like Android.
Comment 2 Ralf Habacker 2014-01-10 13:52:28 UTC
Created attachment 91816 [details] [review]
Fix compile error
Comment 3 Simon McVittie 2014-01-10 14:31:40 UTC
Comment on attachment 91816 [details] [review]
Fix compile error

Review of attachment 91816 [details] [review]:

Thanks, I was going to fix this myself but you got there first :-)

Please commit.
Comment 4 Ralf Habacker 2014-01-10 14:37:15 UTC
Comment on attachment 91816 [details] [review]
Fix compile error

committed to master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.