Bug 7354 - glxextensions.c - posibile write outside variable memory range
Summary: glxextensions.c - posibile write outside variable memory range
Status: RESOLVED NOTABUG
Alias: None
Product: Mesa
Classification: Unclassified
Component: GLX (show other bugs)
Version: 6.5
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-28 15:56 UTC by pinky
Modified: 2006-07-11 11:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
assertin caused by glxinfo (776 bytes, patch)
2006-06-28 15:58 UTC, pinky
Details | Splinter Review
sory, previous is invaid (772 bytes, patch)
2006-06-28 16:07 UTC, pinky
Details | Splinter Review

Description pinky 2006-06-28 15:56:50 UTC
file (Code): src/glx/x11/glxextensions.c LINE: 427
      for ( i = 0 ; known_gl_extensions[i].name != NULL ; i++ ) {
         /* Just in case */
         assert ( i < __NUM_GL_MAX_EXTS );
         const unsigned  bit = known_gl_extensions[i].bit;

         if ( known_gl_extensions[i].client_support ) {
            SET_BIT( client_gl_support, bit );
         }

         if ( known_gl_extensions[i].client_only ) {
            SET_BIT( client_gl_only, bit );
         }

---------------------------
number of items in known_gl_extensions might be greater then size of
client_gl_support*8

so I try apply atached patch, build and run, and -> assert is comming

May someone confirm this?
Comment 1 pinky 2006-06-28 15:58:28 UTC
Created attachment 6070 [details] [review]
assertin caused by glxinfo
Comment 2 pinky 2006-06-28 16:07:31 UTC
Created attachment 6071 [details] [review]
sory, previous is invaid
Comment 3 Tilman Sauerbeck 2006-07-11 11:43:58 UTC
See src/glx/x11/glxextensions.h:208..230.
So the code seems to be correct (and your assertion seems wrong).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.