Bug 7821 - PATCH: unit testing for fixed-point routines
Summary: PATCH: unit testing for fixed-point routines
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.2.1
Hardware: All Linux (All)
: lowest minor
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-09 00:24 UTC by Peter Moulder
Modified: 2008-10-10 16:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
diffs to test/Makefile.am (676 bytes, patch)
2006-08-09 00:26 UTC, Peter Moulder
Details | Splinter Review
new unit test source file test/cairo-fixed.c (2.01 KB, text/plain)
2006-08-09 00:27 UTC, Peter Moulder
Details

Description Peter Moulder 2006-08-09 00:24:57 UTC
src/cairo-fixed.c makes assumptions on the behaviour of shifting a negative int
that aren't guaranteed by C89 spec.  These assumptions may well hold on all
platforms we care about for all I know, but it still highlights the fact that
there's currently no unit testing on the src/cairo-fixed.c routines.

I attach a new unit test (as a patch to test/Makefile.am and a new file
test/cairo-fixed.c).

Possible issue: The new source file test/cairo-fixed.c has the same 
basename as src/cairo-fixed.c.  Clear what it's testing, but may present
a problem for some build tools.  (`make check' works fine for me.)  Feel free to
rename to test/cairo-fixed-test.c (with corresponding changes to test/Makefile.am).
Comment 1 Peter Moulder 2006-08-09 00:26:19 UTC
Created attachment 6503 [details] [review]
diffs to test/Makefile.am
Comment 2 Peter Moulder 2006-08-09 00:27:23 UTC
Created attachment 6504 [details]
new unit test source file test/cairo-fixed.c
Comment 3 Chris Wilson 2008-10-10 16:07:19 UTC
Moved to test-suite TODO.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.