Bug 804 - DRI merge broke build of via driver on non-DRI platforms
Summary: DRI merge broke build of via driver on non-DRI platforms
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Via (show other bugs)
Version: git
Hardware: x86 (IA32) Solaris
: high major
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-26 12:06 UTC by Alan Coopersmith
Modified: 2004-07-15 04:39 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to files in xc/programs/Xserver/hw/xfree86/drivers/via (1.88 KB, patch)
2004-06-26 12:09 UTC, Alan Coopersmith
no flags Details | Splinter Review

Description Alan Coopersmith 2004-06-26 12:06:32 UTC
The DRI merge added #include <drm.h> to hw/xfree86/os-support/xf86drm.h

Unfortunately, the VIA driver was including that file in non-DRI builds,
which now fail with many errors of undefined structures.

It seems simply adding #ifdef XF86DRI to the appropriate places allows the
driver to build, but I don't know enough about the driver to know if this
will break anything, nor do I have any VIA hardware handy to test with, so
I'll simply attach the patch that allowed me to build and let someone else
evaluate it.
Comment 1 Alan Coopersmith 2004-06-26 12:09:27 UTC
Created attachment 420 [details] [review]
Patch to files in xc/programs/Xserver/hw/xfree86/drivers/via
Comment 2 Eric Anholt 2004-07-15 21:39:07 UTC
Committed, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.