Bug 860 - X does not have some of the major indic locales
Summary: X does not have some of the major indic locales
Status: CLOSED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: * Other (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Roland Mainz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-12 20:28 UTC by Leon Ho
Modified: 2011-10-15 16:23 UTC (History)
6 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch for adding these locales (2.15 KB, patch)
2004-08-25 19:05 UTC, Leon Ho
no flags Details | Splinter Review
updated patch with XpConfig/Imakefile (2.99 KB, patch)
2004-10-24 23:18 UTC, Leon Ho
no flags Details | Splinter Review
Final patch with compose.dir (4.00 KB, patch)
2004-10-25 00:22 UTC, Leon Ho
no flags Details | Splinter Review
Diff incl. Changelog entry, patch for 2004-11-04-trunk (17.95 KB, patch)
2004-11-04 16:55 UTC, Roland Mainz
no flags Details | Splinter Review

Description Leon Ho 2004-07-12 20:28:41 UTC
Description of problem:
X does not have those locale available so it will complains when X app
is running under these locales:
bn_IN - Bengali language locale for India
gu_IN - Gujarati language locale for India
pa_IN - Punjabi language locale for India


Version-Release number of selected component (if applicable):


How reproducible:
everytime

Steps to Reproduce:
1. LANG=gu_IN.UTF-8 gedit
  
Actual results:
$ LANG=gu_IN.UTF-8 gedit

(gedit:3306): Gdk-WARNING **: locale not supported by Xlib

(gedit:3306): Gdk-WARNING **: can not set locale modifiers


Expected results:
No complains

Additional info:

Here are the current list of indian langs that available in X
iso8859-15/XLC_LOCALE                   en_IN.ISO8859-15
iscii-dev/XLC_LOCALE                    hi_IN.ISCII-DEV
tscii-0/XLC_LOCALE                      ta_IN.TSCII-0
en_US.UTF-8/XLC_LOCALE                  hi_IN.UTF-8
en_US.UTF-8/XLC_LOCALE                  mr_IN.UTF-8
en_US.UTF-8/XLC_LOCALE                  ta_IN.UTF-8
Comment 1 Leon Ho 2004-08-25 19:05:19 UTC
Created attachment 731 [details] [review]
Patch for adding these locales
Comment 2 Mike A. Harris 2004-09-01 05:14:08 UTC
Can someone review these and commit to CVS, or comment on what is wrong with
it that is preventing it's inclusion in CVS?

Thanks in advance.
Comment 3 Roland Mainz 2004-10-14 07:31:03 UTC
Sun staff should look at the patch - they have working Indic support in Solaris
(incl. CTL support for XLFD-based fonts).

BTW: The patch misses entries in xc/programs/Xserver/XpConfig/Imakefile ...
Comment 4 Leon Ho 2004-10-18 17:20:26 UTC
Ienup Sung from Sun mentioned that the patch is okay. Would you please commit to
the CVS? Thanks

--
By the way, I also think adding locales at locale.dir and locale.alias
as suggested by Leon shouldn't be a problem.

With regards,

Ienup
Comment 5 Leon Ho 2004-10-24 23:18:40 UTC
Created attachment 1160 [details] [review]
updated patch with XpConfig/Imakefile

Here is the patch with XpConfig/Imakefile. It would be great if you can
authorize this and commit into cvs. Thanks!
Comment 6 Roland Mainz 2004-10-24 23:54:13 UTC
Comment on attachment 1160 [details] [review]
updated patch with XpConfig/Imakefile

Leon Ho wrote:
> Here is the patch with > XpConfig/Imakefile.

Thanks! :)

> It would be great if 
> you can authorize this 
> and commit into cvs. 

I am not 100% familar with the xc/nls/-parts of the patch, the people from Sun
are the real experts in that area... :)

Alan/Steve - is the patch OK or are there further adjustments needed ?
Comment 7 Leon Ho 2004-10-25 00:22:37 UTC
Created attachment 1162 [details] [review]
Final patch with compose.dir
Comment 8 Leon Ho 2004-10-25 17:48:27 UTC
Roland, did the comment from Ienup able us to go any further? Or should we
include him into this loop instead from the mailing list? Thanks!
Comment 9 Roland Mainz 2004-11-01 02:08:00 UTC
Leon Ho wrote:
> did the comment from Ienup able us to go any further? Or should we
> include him into this loop instead from the mailing list?

It may be better to include him into this loop (I've emailed him already few
secs ago about that...) ...
Comment 10 Leon Ho 2004-11-01 04:01:34 UTC
Thanks Roland!
This bug has been opened for a while so it is great to get some closure on this.
Cheers.
Comment 11 Ienup Sung 2004-11-01 13:09:13 UTC
(In reply to comment #9)
> Leon Ho wrote:
> > did the comment from Ienup able us to go any further? Or should we
> > include him into this loop instead from the mailing list?
> 
> It may be better to include him into this loop (I've emailed him already few
> secs ago about that...) ...

Thanks for including me. Yes, the changes suggested by Leon looks good to me.
Comment 12 Leon Ho 2004-11-03 16:45:33 UTC
(In reply to comment #11)
> Thanks for including me. Yes, the changes suggested by Leon looks good to me.

Thanks Ienup. 
Roland, thanks in advance on the commit. Cheers.
Comment 13 Roland Mainz 2004-11-04 12:02:44 UTC
Leon Ho wrote:
> (In reply to comment #11)
> > Thanks for including me. Yes, the changes suggested by Leon looks good to 
> > me.
>
> Thanks Ienup. 
> Roland, thanks in advance on the commit. Cheers.

Erm... I assume that means I should commit the patch to CVS, right ?
Comment 14 Leon Ho 2004-11-04 15:48:23 UTC
> > Roland, thanks in advance on the commit. Cheers.
> 
> Erm... I assume that means I should commit the patch to CVS, right ?
> 

Roland, that would be wonderful, as I do not have commit rights. Thanks!
Comment 15 Roland Mainz 2004-11-04 15:55:45 UTC
Leon Ho wrote:
> > > Roland, thanks in advance on the commit. Cheers.
> > 
> > Erm... I assume that means I should commit the patch to CVS, right ?
>
> Roland, that would be wonderful, as I do not have commit rights. Thanks!

OK... who should be listed in the credits (=who wrote the patch (name+email)) ?

----

Taking bug for commit...
Comment 16 Leon Ho 2004-11-04 16:07:04 UTC
(Leon Ho, llch@redhat.com) is fine. Thanks. 

> OK... who should be listed in the credits (=who wrote the patch (name+email)) ?
> 
> ----
> 
> Taking bug for commit...

Comment 17 Roland Mainz 2004-11-04 16:55:41 UTC
Created attachment 1224 [details] [review]
Diff incl. Changelog entry, patch for 2004-11-04-trunk
Comment 18 Roland Mainz 2004-11-04 17:00:30 UTC
Patch checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.504; previous revision: 1.503
/cvs/xorg/xc/nls/compose.dir,v  <--  compose.dir
new revision: 1.5; previous revision: 1.4
/cvs/xorg/xc/nls/locale.alias,v  <--  locale.alias
new revision: 1.5; previous revision: 1.4
/cvs/xorg/xc/nls/locale.dir,v  <--  locale.dir
new revision: 1.4; previous revision: 1.3
/cvs/xorg/xc/programs/Xserver/XpConfig/Imakefile,v  <--  Imakefile
new revision: 1.3; previous revision: 1.2
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.