Building 0.22.1 on OS X 10.8, I get warnings: p11-kit/rpc-message.c:174:14: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (call_id < 0 || call_id >= P11_RPC_CALL_MAX) { ~~~~~~~ ^ ~ trust/index.c:902:12: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (count < (CK_ULONG)0UL) ~~~~~ ^ ~~~~~~~~~~~~~ In each case, the variable is an unsigned type, so by definition it is >= 0. Not sure what the intent of these code sections are, whether the variable should be signed or if the test should be scrapped, or whatever else
Created attachment 109449 [details] [review] p11-kit, trust: Fix issues with comparing unsigned integers These were caught by Clang on OS X 10.8
Does this patch fix the issue?
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.