Bug 86865 - No protocol specified on gnome-initial-setup
Summary: No protocol specified on gnome-initial-setup
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium major
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-30 02:30 UTC by Alban Browaeys
Modified: 2015-09-22 05:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
le family local go through the validhosts checks (1.12 KB, text/plain)
2014-11-30 02:30 UTC, Alban Browaeys
no flags Details

Description Alban Browaeys 2014-11-30 02:30:19 UTC
Created attachment 110255 [details]
le family local go through the validhosts checks

xserver returns early in ClientAuthorized > InvalidHost without checking via get_pwnam after the 2566835b commit (Eliminate uninitialized value warnings from access.c) . This is with FamilyLocal , ConvertAddress returns immediatly thus addr is kept null (family is set to 256. Then the commit that eliminate uninitialized value went too far as to check for addr null before siAddrMatch .

siAddrMatch called into get_pwname before this commit via siLocalCredAddrMatch then siLocalCredGetId.

This breaks gdm initial setup (gnoem-continuous which is at 1.16.99.901 . Tested against master too .

The attached patch removed the check for null an addr before siAddrMatch and addrEqual (the latter for consistency as in the same context ).
Comment 1 Alan Coopersmith 2015-09-22 05:42:09 UTC
Fixed in git master by:
http://cgit.freedesktop.org/xorg/xserver/commit/?id=9d9bd38fe1454590c303dc936ddac913808bf881

(Sorry, the xserver maintainer doesn't read bugzilla, so only sees patches
 mailed to xorg-devel mailing list.)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.