Bug 89174 - The gstreamer plugin should not accept an already formed startup notify id
Summary: The gstreamer plugin should not accept an already formed startup notify id
Status: RESOLVED NOTABUG
Alias: None
Product: PackageKit
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-16 21:08 UTC by Giovanni Campagna
Modified: 2018-08-21 15:52 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Giovanni Campagna 2015-02-16 21:08:02 UTC
I was looking through the new API for plugin installation (and other Modify2 methods), and one comment I have is that letting the apps create the startup notify id means that true startup notification is impossible (because the app does not know the desktop id of whoever is responsible for installing the plugin, gnome-software or apper or whatever).

_TIME%d is enough to fix focus stealing prevention, but does not offer feedback for app launching, which means that the user will be staring at nothing happening until finally gnome-software launches (which can take a while, given the amount of IO g-s triggers through PackageKit).

Instead, the PackageKit plugin should create a real startup notify id (with g_app_launch_context_get_startup_notify_id()), using the timestamp provided by the application, and pass that to Modify.
This will make sure that even if gnome-software or apper slow to launch the user is aware that something is happening.

As for which desktop file should be associated with the startup notify id, given that multiple providers for the Modify2 interface exists, I'd say it can be fixed with DE detection or with a configuration file. After all, you cannot install apper and gnome-software at the same time because they offer the same DBus service, which is not allowed.
Comment 1 Richard Hughes 2018-08-21 15:52:45 UTC
We moved the upstream bugtracker to GitHub a long time ago. If this issue still affects you please re-create the issue here: https://github.com/hughsie/PackageKit/issues
 
Sorry for the impersonal message, and fingers crossed your issue no longer happens. Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.